-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-address support to "Faucet" button #2533
base: dev
Are you sure you want to change the base?
Add multi-address support to "Faucet" button #2533
Conversation
Remove the faucet button from the coin overview and add it as a button icon in the addresses list Move references to faucet_button.dart from the details page to the coin address list. Note that you might have to change how the page is called in coin_details.dart to pass the selected address of the coin (rather than defaultAddress) NB: Take a branch from dev and name it add/multi-address-faucet
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The button would disappear when the browser was minimized to mobile size. Also did some UI changes to make the button look more like swap address.
Remove the faucet button from the coin overview and add it as a button icon in the addresses list
Move references to faucet_button.dart from the details page to the coin address list. Note that you might have to change how the page is called in coin_details.dart to pass the selected address of the coin (rather than defaultAddress)