Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimal bar-[INS-4420] #8293

Merged
merged 6 commits into from
Feb 17, 2025
Merged

feat: minimal bar-[INS-4420] #8293

merged 6 commits into from
Feb 17, 2025

Conversation

CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented Jan 14, 2025

Changes

  1. add isMinimal state to control different UI
  2. extract the "Online" component because it is at different position when minimal
  3. extract the repeat UserButton and InviteButton component in Header
Screen.Recording.2025-01-15.at.18.02.16.mov

@CurryYangxx CurryYangxx marked this pull request as draft January 14, 2025 02:45
@CurryYangxx CurryYangxx requested a review from a team January 15, 2025 10:17
@notjaywu notjaywu marked this pull request as ready for review January 17, 2025 01:02
@cwangsmv
Copy link
Contributor

Nit: User email is truncated when in smaller width window.

Default:
Screenshot 2025-02-12 at 17 49 07

Minimal Bar:
Screenshot 2025-02-12 at 17 48 59

)}
</div>
{!isMinimal && (
<div className="flex gap-[--padding-sm] items-center justify-end p-2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should extract the invite button and user button to standalone components here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree

@CurryYangxx
Copy link
Member Author

Nit: User email is truncated when in smaller width window.

Default: Screenshot 2025-02-12 at 17 49 07

Minimal Bar: Screenshot 2025-02-12 at 17 48 59

@cwangsmv Good catch! I updated style, when there is not enough space, the middle column will be compressed.
image

yaoweiprc
yaoweiprc previously approved these changes Feb 13, 2025
@CurryYangxx CurryYangxx disabled auto-merge February 17, 2025 07:36
@CurryYangxx CurryYangxx merged commit a3589d9 into develop Feb 17, 2025
8 of 9 checks passed
@CurryYangxx CurryYangxx deleted the feat/minimal-bar branch February 17, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants