feat: preference for key map with one-line text fields #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-willis
requested review from
jackkav and
CurryYangxx
and removed request for
jackkav
jackkav
previously approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Looks good, but since I think it pairs with another setting it's a good time to confirm that the default is reasonable. I don't use a custom key map but if I did I guess I would only expect it to work in multi line inputs unless I toggle something on. I might be mistaken on this but worth considering before naming the something hard to change.
I agree, and I'm leaning toward that as well. I feel that enrolling all users into a default preference that changes the UX would better suit the next major version, so perhaps we should wait on this one until then? |
CurryYangxx
previously approved these changes
Feb 13, 2025
ryan-willis
dismissed stale reviews from CurryYangxx and jackkav
via
a6bd0ad
ryan-willis
force-pushed
the
feat/one-line-ux-setting
branch
from
6244f0b to
a6bd0ad
Compare
ryan-willis
changed the title
ryan-willis
force-pushed
the
feat/one-line-ux-setting
branch
from
a6bd0ad to
8a2ab67
Compare
ryan-willis
force-pushed
the
feat/one-line-ux-setting
branch
from
205fbee to
70b5abc
Compare
jackkav
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(due to my own personal reeling from a one-line vim cursor)
key map will be disabled when editing a
literal(one-line: key/value, url), and only apply tocode(multi-line: body, script) by defaultusers can turn it back on in preferences