Spike: remove part of multiple abstraction-[INS-4911] #8362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* runner improvements * runner improvement * maintain runner state in context * fix lint * save file object to context * add request list to runner context to keep order * fix ts error * add eventbus & clear runner context state * also delete folder runner tab when delete a folder * clean * change runner context data structure * clean up
* fix: runner not update * also delete folder runner tab when delete a folder * fix: keep websocket connection * feat: keep grpc&websocket connection * unify close connection after tab closed * del repeat func * close graphql subscription * resolve conflict * feat: close connections when active environment change * add desc for hooks * close connections when organization change
* test: multiple tab * fix: dashboard test
CurryYangxx
changed the title
CurryYangxx
force-pushed
the
spike/simplify-multiple-tab
branch
from
59c61b3 to
d8e0e0a
Compare
CurryYangxx
force-pushed
the
spike/simplify-multiple-tab
branch
from
d8e0e0a to
a2ee656
Compare
CurryYangxx
force-pushed
the
spike/simplify-multiple-tab
branch
from
66c4efc to
fc39ba7
Compare
|
@jackkav I removed part of the abstraction and put the logic back to the same file. Hope this can help you understand the logic better. |
CurryYangxx
force-pushed
the
feat/multiple-tab
branch
4 times, most recently
from
c7af264 to
a3128f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove useRequestRunnerList and useInsomniaTab abstraction