Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Try to improve smoke test tracing to figure failure/flaky case causes [INS-5056] #8431

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

cwangsmv
Copy link
Contributor

Current smoke test tracing logic has the following issues:

  • Although we set trace mode to 'retain-on-failure', it actually captures traces for every test case, no matter sucess or failure. As a result, the trace file is too huge to navigator to failed cases easily.
  • The tracing file for common flaky cases with 'timeout' problems does not contain screenshots. This made it difficult to triage root causes of the flaky cases.

Fix these issues with conditional tracing logic and fix two failed cases cause by the tracing change

@cwangsmv cwangsmv marked this pull request as draft February 27, 2025 12:46
@cwangsmv cwangsmv force-pushed the fix/improve-playwright-tracing branch from 16bef48 to eaed49b Compare February 28, 2025 03:15
@cwangsmv cwangsmv changed the title chore: Try to improve smoke test tracing to figure failure/flaky case causes chore: Try to improve smoke test tracing to figure failure/flaky case causes [INS-5056] Mar 3, 2025
@cwangsmv cwangsmv marked this pull request as ready for review March 4, 2025 05:42
@cwangsmv cwangsmv requested review from CurryYangxx and jackkav March 4, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant