Migrate usages of AccessOverload APIs in inline functions to public alternatives #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koperagen
force-pushed
the
migrate-inlined-internal-api
branch
from
dd08be6 to
44d9591
Compare
Jolanrensen
reviewed
Apr 30, 2025
| @@ -1177,8 +1177,9 @@ class DataFrameTests : BaseTest() { | |||
| .split { others }.intoRows() | |||
| .add(sum) { name.length + other().length } | |||
|
|
|||
| val matrix = src.pivot { other }.groupBy { name }.with { sum } | |||
| val matrix = src.pivot { other }.groupBy { name }.with { sum() } | |||
There was a problem hiding this comment.
why are these brackets now needed?
There was a problem hiding this comment.
with is a "row expression", and in this test it used to be that return type is ColumnReference, not value. Techically i didn't had to change sum => sum() because i kept the branch that handles this case for compatibility (at least in this pr), but decided to change usage anyway
koperagen
force-pushed
the
migrate-inlined-internal-api
branch
from
44d9591 to
07044c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1156
With Public API modifier enabled, such calls to AccessOverload APIs won't compile. We cannot make them PublishedAPI