Util functions fixes #1412
Merged
Util functions fixes #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jolanrensen
requested changes
Aug 27, 2025
| * and returns `true` if it matches the condition. | ||
| * @return `true` if at least one element matches the [predicate], `false` otherwise. | ||
| * @see [DataColumn.all] | ||
| * @see [DataColumn.filter] |
There was a problem hiding this comment.
I don't think filter and count are very relevant, only all
There was a problem hiding this comment.
Why? IMHO these functions are really related.
There was a problem hiding this comment.
Since they all operate on column values with a Boolean condition.
There was a problem hiding this comment.
well so does takeWhile, dropWhile and I can think of some more.
I would only group all {} and any {} since they both reduce to a single boolean:
Column<T>.function(predicate: (T) -> Boolean): Boolean
(none {} would be here too, if we had it... do we?)
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/api/tail.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Create.kt
Outdated
Show resolved
Hide resolved
...frame-plugin-example/src/main/kotlin/org/jetbrains/kotlinx/dataframe/examples/plugin/Main.kt
Outdated
Show resolved
Hide resolved
zaleslaw
approved these changes
Aug 28, 2025
Jolanrensen
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KDocs and tests for a set of small util functions + deprecate obsolete ones.
Closes #1389