DateTimeComponents.Format parse throws an exception when timeZoneId() is UTC #528
+249
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dkhalanskyjb Dmitry, hello! Could you please look at the added tests, do they correctly document the expected behavior and fully cover possible scenarios? Thank you! |
dkhalanskyjb
requested changes
May 20, 2025
|
|
||
| fun validateHH() = validateTimeComponent(2, 18) | ||
| fun validateH() = validateTimeComponent(1, 9) | ||
| fun validateMM() = validateTimeComponent(2, 59) { minutes -> hours < 18 || minutes == 0 } |
There was a problem hiding this comment.
There are also seconds (UTC+011530, UTC+01:15:30 can both be passed to TimeZone.of), but before implementing their support, let's have a discussion tomorrow about which behaviors we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TimeZone parser implementation using Finite State Automaton
This PR introduces a robust parser for timezone identifiers using a finite state automaton approach.
The parser handles several timezone representation formats including special named timezones (UTC, GMT, UT, Z), fixed offsets with different notation styles (+01:00, +0100, +01) and combined formats (UTC+01:00, GMT-05:00).
At the core of the implementation is a state machine that transitions through different states as it processes the input character by character. The automaton begins in a START state and transitions through states such as AFTER_PREFIX (after parsing UTC/GMT/UT), AFTER_SIGN (after + or -), AFTER_HOUR, and AFTER_COLON based on the input characters.
The parser stores the last valid index encountered during parsing, which enables it to provide meaningful error messages and handle cases where the timezone identifier is followed by other characters.
Comprehensive test coverage validates the parser's behavior across various use cases, including handling of edge cases like invalid offset values (e.g., +25:00), malformed offsets (e.g., +1:), and rejection of non-standard identifiers. The tests confirm that the parser correctly validates timezone identifiers according to expected standards while appropriately rejecting invalid formats.