-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][GeneratorBundle] Commands to generate new website skeleton and default pageparts #2512
Open
acrobat
wants to merge
16
commits into
Kunstmaan:6.x
Choose a base branch
from
acrobat:new-website-skeleton
base: 6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfessorKuma
approved these changes
Jul 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @, your PR passed all our requirements.
Thank you for contributing!
acrobat
force-pushed
the
new-website-skeleton
branch
3 times, most recently
from
July 8, 2019 09:03
a8cac92
to
8584800
Compare
acrobat
changed the title
[GeneratorBundle] Commands to generate new website skeleton and default pageparts
[WIP][GeneratorBundle] Commands to generate new website skeleton and default pageparts
Sep 18, 2019
acrobat
force-pushed
the
new-website-skeleton
branch
from
December 10, 2019 12:24
7fa0351
to
845577c
Compare
acrobat
force-pushed
the
new-website-skeleton
branch
from
October 12, 2021 10:08
21b2a94
to
6ed502e
Compare
acrobat
force-pushed
the
new-website-skeleton
branch
from
October 25, 2021 15:55
6ed502e
to
542c516
Compare
Co-authored-by: Kevin Fivé <[email protected]> Co-authored-by: "piet.dewijngaert" <[email protected]>
acrobat
force-pushed
the
new-website-skeleton
branch
from
July 14, 2022 06:49
542c516
to
f902f9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 new maker commands to generate a new (improved for symfony 4) website skeleton and a new set of default pageparts. There is also a spacer pp added to allow setting custom spacings between pageparts. The functionality, to add this pagepart automatically after a pagepart is added, is disabled by default. Some work is needed to make this fully configurable.
TODO:
@experimental
. To allow fast changes (that possibly break BC) in case of big issuesasset()
twig function where we include images instead of hardcoded paths