Fixing several bugs #181
Merged
Fixing several bugs #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi,
There's a lot of changes in here that change default behaviour, right?
I propose a discussion of these including @Iranaphor
@GPrathap you can continue to work on this (or make a new branch for new features) but I'm reluctant to merge without a proper discussion first.
| "goal_checker.xy_goal_tolerance": 0.78, | ||
| "goal_checker.yaw_goal_tolerance": 0.25, | ||
| "goal_checker.xy_goal_tolerance": 1.0, | ||
| "goal_checker.yaw_goal_tolerance": 1.25, |
There was a problem hiding this comment.
I would argue this changes default behaviour?
| @@ -60,7 +64,7 @@ def __init__(self): | |||
| } | |||
|
|
|||
| self.bt_tree_with_control_server_config = {} | |||
| self.bt_tree_with_control_server_config[self.ROW_TRAVERSAL] = "dwb_core::DWBLocalPlanner" | |||
| self.bt_tree_with_control_server_config[self.ROW_TRAVERSAL] = "teb_local_planner::TebLocalPlannerROS" | |||
There was a problem hiding this comment.
Again,.this changes default behaviour significantly?!
| @@ -86,8 +86,9 @@ def __init__(self, name, mode): | |||
| self.navigation_action_name = self.get_parameter_or("navigation_action_name", Parameter('str', Parameter.Type.STRING, self.ACTIONS.NAVIGATE_TO_POSE)).value | |||
| self.navigation_actions = self.get_parameter_or("navigation_actions", Parameter('str', Parameter.Type.STRING_ARRAY, self.ACTIONS.navigation_actions)).value | |||
|
|
|||
| self.use_nav2_follow_route = self.get_parameter_or("use_nav2_follow_route", Parameter('bool', Parameter.Type.BOOL, False)).value | |||
| self.use_nav2_follow_route = self.get_parameter_or("use_nav2_follow_route", Parameter('bool', Parameter.Type.BOOL, True)).value | |||
marc-hanheide
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Fixing several bugs that occurred during testing
QA Instructions, Screenshots, Recordings
There is no new functionality was added.