Make example scripts more portable #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts more POSIX-friendly
The use of read(1) in the innermost loop wasn't properly capturing the piped-in values, and would hang forever waiting for input. The syntax used in the original swww_randomize_multi.sh does not have this problem. I don't really understand how the other syntax does not also have this problem, but I am reverting it so that it at least works. I removed the $ in front of the $img variable when unsetting it, since including it was expanding the variable. Oops!
filip-rs
approved these changes
Mar 5, 2025
|
My bad, I had forgotten to merge this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to make
swww_randomize.shandswww_randomize_multi.shmore portable by replacing the$RANDOMbash-ism with more portable way of randomizing the files.This also removes
swww_randomize_multi.sh's check to make sure it is not already running, since it uses$BASHPID. In my subjective opinion, such logic is not needed in the first place, since these scripts are likely to be run once by the compositor automatically rather than manually invoked multiple times. That said, if it is required, I will write a portable solution that doesn't use$BASHPIDand apply that solution inswww_randomize.shas well, which currently lacks this check.