Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Any by UnknownAttributeStorage to handle collections in attribute manager #97

Merged
merged 11 commits into from
Jun 12, 2024

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Jun 10, 2024

Note: It looks like downcast-rs isn't used, but if you remove the Downcast trait from UnknownAttributeStorage, the code won't compile.

Scope

  • Code

Type of change

  • New feature(s)
  • Refactor

Other

Necessary follow-up

  • Needs testing
  • Other: with these new methods, it should be possible to add the manager to CMap2 & wire everything up to handle attributes automatically

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 120 lines in your changes missing coverage. Please review.

Project coverage is 79.46%. Comparing base (ea6dc58) to head (b481b90).

Files Patch % Lines
honeycomb-core/src/attributes/manager.rs 0.00% 120 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   83.00%   79.46%   -3.55%     
==========================================
  Files          27       27              
  Lines        2601     2717     +116     
==========================================
  Hits         2159     2159              
- Misses        442      558     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imrn99 imrn99 marked this pull request as ready for review June 10, 2024 13:44
@imrn99 imrn99 merged commit 162fa81 into master Jun 12, 2024
13 checks passed
@imrn99 imrn99 deleted the replace-any-with-unknown-storage branch June 12, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out how to downcast each Box<dyn Any> object correctly when iterating over all storages
3 participants