replace Any
by UnknownAttributeStorage
to handle collections in attribute manager
#97
+283
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Box<dyn Any>
object correctly when iterating over all storages #93Note: It looks like
downcast-rs
isn't used, but if you remove theDowncast
trait fromUnknownAttributeStorage
, the code won't compile.Scope
Type of change
Other
downcast-rs
; Necessary untiltrait_upcasting
is stabilized Tracking issue for dyn upcasting coercion rust-lang/rust#65991Necessary follow-up
CMap2
& wire everything up to handle attributes automatically