Skip to content

Commit

Permalink
Fix tests and GLUE finetuning (fixes facebookresearch#989)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: facebookresearch#991

Differential Revision: D16687970

Pulled By: myleott

fbshipit-source-id: d877fc16891a8ab97aec47a8d440baa56c2b5f46
  • Loading branch information
Myle Ott authored and facebook-github-bot committed Aug 7, 2019
1 parent 2b7843d commit 1e55bbd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fairseq/data/base_wrapper_dataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,5 @@ def prefetch(self, indices):

def set_epoch(self, epoch):
super().set_epoch(epoch)
self.dataset.set_epoch(epoch)
if hasattr(self.dataset, 'set_epoch'):
self.dataset.set_epoch(epoch)
4 changes: 4 additions & 0 deletions fairseq/models/transformer_lm.py
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,9 @@ def base_lm_architecture(args):
if hasattr(args, 'decoder_final_norm'):
args.no_decoder_final_norm = not args.decoder_final_norm

args.dropout = getattr(args, 'dropout', 0.1)
args.attention_dropout = getattr(args, 'attention_dropout', 0.0)

args.decoder_embed_dim = getattr(args, 'decoder_embed_dim', 512)
args.decoder_ffn_embed_dim = getattr(args, 'decoder_ffn_embed_dim', 2048)
args.decoder_layers = getattr(args, 'decoder_layers', 6)
Expand All @@ -161,6 +164,7 @@ def base_lm_architecture(args):
args.activation_fn = getattr(args, 'activation_fn', 'relu')

args.add_bos_token = getattr(args, 'add_bos_token', False)
args.no_token_positional_embeddings = getattr(args, 'no_token_positional_embeddings', False)
args.share_decoder_input_output_embed = getattr(args, 'share_decoder_input_output_embed', False)
args.character_embeddings = getattr(args, 'character_embeddings', False)

Expand Down

0 comments on commit 1e55bbd

Please sign in to comment.