Docker containers #604
Open
Docker containers #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: for general SCR development, continuous integration (CI) testing, and for running on rabbits, SCR should be able to build in a container. Copy over flux-framework/flux-core and flux-framework/flux-sched's docker infrastructure. See github.com/flux-framework/flux-core/tree/master/src/test/docker
Problem: the docker infrastructure from flux-core has a lot of Flux-specific logic not needed here. Remove it.
jameshcorbett
force-pushed
the
github-ci-containers
branch
from
af63c94 to
bdf081d
Compare
|
See the Github actions running in my fork: https://github.com/jameshcorbett/scr/actions/runs/14098077240 A bunch of the checks fail but they all build successfully, so I don't view the checks failing as a barrier to this going in. And I think with a bit more work the tests could start to pass as well. |
jameshcorbett
force-pushed
the
github-ci-containers
branch
2 times, most recently
from
cb27b8d to
a147bdf
Compare
Problem: some different linux distros are needed for running tests. Add el9 and fedora40 containers.
Problem: more linux distros should be included in the docker containers. Add noble, alpine, and bookworm.
Problem: the docker infrastructure copied over from flux-core includes a 'checks' dockerfile that is used to set a user, but it ends up complicating things. Remove the 'checks' dockerfile and use a script instead to set a user.
Problem: add github workflow is needed to start building and testing SCR in GitHub actions. Add a workflow.
Problem: a script is needed to generate the GitHub CI matrix. Add a script, copying it over from flux-core with modifications.
jameshcorbett
force-pushed
the
github-ci-containers
branch
from
7fd520f to
918fc71
Compare
CamStan
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: for general SCR development, continuous integration (CI)
testing, and for running on rabbits, SCR should be able to build
in a container.
Copy over flux-framework/flux-core and flux-framework/flux-sched's
docker infrastructure. (See https://github.com/flux-framework/flux-core/tree/master/src/test/docker for reference)
Images are hosted here: https://hub.docker.com/r/libscr/scr/tags