-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FFmpeg #6430
base: master
Are you sure you want to change the base?
Add FFmpeg #6430
Conversation
As the build shows, your PR fails the CI on all machines:
I recommend making this PR a draft until you get it working. |
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/e183266e-22e7-40bf-95f1-fb015a1f489b/artifacts/0/lmms-1.3.0-alpha.1.186+g9dbe66fa1-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/380?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/7fcc3270-3e3e-4f81-83dc-92502a2f3950/artifacts/0/lmms-1.3.0-alpha.1.186+g9dbe66fa1-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/377?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/99c49b6e-c6ee-4c82-a75f-c4ff7d067821/artifacts/0/lmms-1.3.0-alpha.1.186+g9dbe66fa1-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/378?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "9dbe66fa1afcbe54411f7f17d3a08c1b09b7bbe9"} |
eab50ba
to
9dbe66f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional comments:
- CMake modules should use tabs for indentation, not 2 spaces
- Installing ffmpeg for MinGW should probably be moved to
lmms-ci-docker
repository. I'll also ask @tobydox to create MinGW PPA packages for ffmpeg later.
Co-authored-by: Hyunjin Song <[email protected]>
Yeah, I figured that would be the best way to go about it but I realized tobydox didn't have FFmpeg packages in his PPA. To my surprise I thought I could get pre-built FFmpeg packages for MinGW somewhere else, but I suppose not. |
…th and find_library, use IN_LIST instead of index searching for components, and convert indentation to tabs Co-authored-by: Hyunjin Song <[email protected]>
Forgot to explain why I made this a draft over here. I made this a draft because I'm waiting for @tobydox to add FFmpeg MinGW packages in his PPA. That way, we can move FFmpeg for MinGW to the docker images themselves without having to cross compile FFmpeg, as to which I'll adjust this PR accordingly. The "Install FFMpeg" step for Linux will also be moved to the docker images. |
Adds the FFmpeg library. Meant to replace sndfile in the future. Using FFmpeg comes with its own advantages, such as the support for a plethora of audio codecs and formats.