Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FFmpeg #6430

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Add FFmpeg #6430

wants to merge 8 commits into from

Conversation

sakertooth
Copy link
Contributor

@sakertooth sakertooth commented Jun 11, 2022

Adds the FFmpeg library. Meant to replace sndfile in the future. Using FFmpeg comes with its own advantages, such as the support for a plethora of audio codecs and formats.

@JohannesLorenz
Copy link
Contributor

As the build shows, your PR fails the CI on all machines:

CMake Error at /usr/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:211 (message):
  No REQUIRED_VARS specified for FIND_PACKAGE_HANDLE_STANDARD_ARGS()
Call Stack (most recent call first):
  cmake/modules/FindFFmpeg.cmake:97 (find_package_handle_standard_args)
  CMakeLists.txt:199 (FIND_PACKAGE)

I recommend making this PR a draft until you get it working.

@sakertooth sakertooth marked this pull request as draft June 11, 2022 14:29
@LmmsBot
Copy link

LmmsBot commented Jun 11, 2022

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://output.circle-artifacts.com/output/job/e183266e-22e7-40bf-95f1-fb015a1f489b/artifacts/0/lmms-1.3.0-alpha.1.186+g9dbe66fa1-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/380?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/7fcc3270-3e3e-4f81-83dc-92502a2f3950/artifacts/0/lmms-1.3.0-alpha.1.186+g9dbe66fa1-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/377?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://output.circle-artifacts.com/output/job/99c49b6e-c6ee-4c82-a75f-c4ff7d067821/artifacts/0/lmms-1.3.0-alpha.1.186+g9dbe66fa1-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/sakertooth/lmms/378?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "9dbe66fa1afcbe54411f7f17d3a08c1b09b7bbe9"}

@sakertooth sakertooth force-pushed the add-ffmpeg branch 2 times, most recently from eab50ba to 9dbe66f Compare July 21, 2022 01:47
@sakertooth sakertooth marked this pull request as ready for review August 22, 2022 06:47
Copy link
Member

@PhysSong PhysSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments:

  • CMake modules should use tabs for indentation, not 2 spaces
  • Installing ffmpeg for MinGW should probably be moved to lmms-ci-docker repository. I'll also ask @tobydox to create MinGW PPA packages for ffmpeg later.

@sakertooth
Copy link
Contributor Author

sakertooth commented Aug 22, 2022

* Installing ffmpeg for MinGW should probably be moved to [`lmms-ci-docker`](https://github.com/LMMS/lmms-ci-docker) repository. I'll also ask @tobydox to create MinGW PPA packages for ffmpeg later.

Yeah, I figured that would be the best way to go about it but I realized tobydox didn't have FFmpeg packages in his PPA. To my surprise I thought I could get pre-built FFmpeg packages for MinGW somewhere else, but I suppose not.

…th and find_library, use IN_LIST instead of index searching for components, and convert indentation to tabs

Co-authored-by: Hyunjin Song <[email protected]>
@sakertooth sakertooth marked this pull request as draft August 24, 2022 18:21
@sakertooth
Copy link
Contributor Author

Forgot to explain why I made this a draft over here.

I made this a draft because I'm waiting for @tobydox to add FFmpeg MinGW packages in his PPA. That way, we can move FFmpeg for MinGW to the docker images themselves without having to cross compile FFmpeg, as to which I'll adjust this PR accordingly. The "Install FFMpeg" step for Linux will also be moved to the docker images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants