Fix resize issues #7524
Fix resize issues #7524
Conversation
|
@JohannesLorenz i believe #7438 (and a follow up for resizeability) will fix the glitch better than working on the existing effect view. |
My PR does not touch effects at all. So what you say may be true (in a trivial way), but does not make my PR wrong or unnecessary. |
|
|
JohannesLorenz
force-pushed
the
resizability
branch
from
e9827b0 to
0b57f4a
Compare
|
This fixes #7510 for me. I haven't tested it extensively and I only reproduced it on a few plugins (caps) but it looks like it's fixed here. |
JohannesLorenz
force-pushed
the
resizability
branch
from
0b57f4a to
a2cb835
Compare
|
Syncing subwindow and embed's sizes seems rather redundant. From my testing just setting I did basically this in #3532, you could as well test how it works. |
Imagine a window has a variable width, and the height has a minimum and maximum value. Can you still model such a case?
I will close this PR because I think this should be handled in #3532 - that PR likely has more useful test scenarios. Aside from his, please keep in mind: Since you started to fix an issue in #3532, namely #7510, you should better first have checked that issue for if anyone is working on it - I referenced my PR there in September 2024. Checking issues that we solve can help prevent that two devs work on the same issue. |
This is a split-of from lv2-ui which consists of many things I had to do to display Lv2 effects properly (and possibly fix other bugs).
This seems to finally be a good PR, but it might still require being extended, see #7510 (comment) .