Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generating unique names for new tracks #7557

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

szeli1
Copy link
Contributor

@szeli1 szeli1 commented Oct 22, 2024

This Pull request adds 2 methods that assigns numbers to tracks that would have the same name otherwise.

Tracks with the same name are still possible, but all new tracks and all cloned tracks will have a unique name by default. Instruments of the same kind will also have differentiating numbers added to them.

Tracks loaded from a save should not be effected.

Issues:

  • Tracks that have names consisting only from digits will get the absolute highest number across all tracks. (if 1. track is named "12" and 2. track is named "automation 42", and if the 1. Track is cloned, then the new name will be "43" instead of "13")
  • Change how PatternTrack clones are named #7550 does the same thing, but only in pattern track

@JohannesLorenz JohannesLorenz added needs style review A style review is currently required for this PR needs code review A functional code review is currently required for this PR needs testing This pull request needs more testing labels Nov 20, 2024
@JohannesLorenz
Copy link
Contributor

Does this close an existing issue?

@szeli1
Copy link
Contributor Author

szeli1 commented Nov 21, 2024

Does this close an existing issue?

I believe there is no open issue about this on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs code review A functional code review is currently required for this PR needs style review A style review is currently required for this PR needs testing This pull request needs more testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants