Add Beat Preview to PatternClipView #7559
Draft
+64
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way PatternClips are drawn in include a simple "beat preivew," where each note in any non-empty instrument tracks within the pattern are drawn as 1/16 long rectangles on the ClipView. SampleClips and AutomationClips within patterns are not currently supported.
Note
I am not currently satisfied with the state of the visualization; perhaps some of you may have ideas on how to make it better, and/or if it should be optional (perhaps the solid color clips could be appealing to some)
Demo
pattern_clip_view_beat_preview_demo.mp4
(why is github thinking this is an audio file?)
Todo