Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable focus for new channel button #7597

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

sakertooth
Copy link
Contributor

Disable grabbing focus for the new channel button in Mixer. I think this button grabbing focus goes against expectations but let me know what you think.

@michaelgregorius
Copy link
Contributor

I guess it makes sense as there's also no indication that the button has the focus.

For anybody wondering, the following does not work anymore after this PR:

  • Click the "Add channel" button
  • Hit the space bar several times to add more channels

Does not seem critical to me though because I assume that it's not really a common use case that users want to add tons of channels upfront and quickly as described above.

@sakertooth
Copy link
Contributor Author

I made this PR mainly because users may want to start and stop the song with the Spacebar, but they might not even realize that the new channel button has focus. If any major objections pop up though, I am mostly fine with reverting.

@sakertooth sakertooth merged commit 5acc796 into LMMS:master Nov 27, 2024
11 checks passed
@sakertooth sakertooth deleted the disable-focus-new-channel-btn branch November 27, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants