Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert pkgconf removal #7605

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Conversation

messmerd
Copy link
Member

@messmerd messmerd commented Nov 27, 2024

Reverts #7593 since the upstream issues have been fixed.

Replaces pkg-config with the drop-in replacement pkgconf which Homebrew and GitHub Actions have migrated to.

@messmerd messmerd requested a review from DomClark November 27, 2024 00:49
@sakertooth
Copy link
Contributor

I was fine with this PR, but I see you are requesting a review from @DomClark. I wont merge if you want that review from him.

@messmerd
Copy link
Member Author

messmerd commented Dec 1, 2024

I just requested a review from Dom due to his comment in the other PR: #7593 (comment)

It should be good to merge.

@messmerd messmerd merged commit d973788 into LMMS:master Dec 1, 2024
11 checks passed
@messmerd messmerd deleted the revert-pkgconf-removal branch December 1, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants