-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major German translation rework (01/12/2024) #7612
Conversation
I've been asked to try a (non-official) review to get this merged more easily. While I cannot check the technical side of this XML, I could see whether the language part is ok. But given that the overall structure changes that much. My diff tools are of no use. From skimming over the entries I only found some minor nits, such as:
If you're just interested in a general feedback I'd say "looks benign and good". Also IMO it was well-chosen what terms shall not be translated and technical terms were translated with the subject area in mind. If I shall help with a more thorough review I need some way to focus the actual differences this patch performs. Hope this helps a little. |
Thanks for the review! Yes, this diff is large, it's probably easier to review if you just open the file in Qt Linguist because my changes went over the entire file anyway. I would strongly recommend you compile the application to see the strings in action to catch issues like when a text is too large for a button or something like that. I did my own tests already btw. Comments:
As for the difficult technical terms, you're correct. I tried my best to research beyond the dictionary and only picked a translation when I was sufficiently sure it was the correct translation. |
TIL
Will do. Afaik you can omit the hyphenation if both words are German or eingedeutscht. That's why I'd chose "Computerraum" as well.
I don't have a lot of spare time and I don't even know the application :) I've been asked for a second opinion on the translation and I want to make sure this massive contribution can get merged soon. I'm currently creating my own diff of the two documents to maybe assemble a complete list of errata or just green-light everything as "way better than before". |
BTW are |
I like that you use proper punctuation (such as Some corrections and suggestions (most of them are super nit-picky - don't feel pressed to address them all):
I'm super sorry, but I cannot invest more time :( My overall feedback: this is an extremely well-written translation and a huge amount of work. The author obviously has deeper domain knowledge and cares a lot for proper German localization (not just translation and grammar). Even without addressing the above points this PR will greatly improve over the status quo, mainly by adding thousands of missing translations. (for context: I'm a German software developer who worked on an online DAW for several years) |
Thank you! My domain knowledge is not actually deep, not an audio expert here. I just looked on the Internet to try to de-mystify some technical terms. I think the remaining strings I could not translate require some serious expert knowledge. I updated this PR again and adressed most of the things except when I disagree.
|
Most of the technical terms looked correct to me or at least good enough to not cause confusion.
Ah, I didn't know the context. I agree.
Looks like both languages would benefit from an associativity operator then :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you both are okay with merge or if it should wait a bit. |
All good from my side. |
Yes, this is ready for merge. |
This reverts commit 088a2cb.
This PR is a major translation work of the German translation. I felt this was neccessary because of many mistakes and just missing translations.
Mistakes in current German translation (that this PR fixes, hopefully) include:
After my first failed attempt to update the German translation (#7602), I’ve had another go under
master
.I used
lupdate
and some manual merging of my previous work to get this done.This was my
lupdate
line:lupdate -locations none -I include plugins plugins/* plugins/*/* src/* src/*/* -ts data/locale/de.ts
This is loosely based on what I found in CMake files and I'm not sure if this line captures every string in LMMS, but it seems close. If I missed an important directory, please let me know. The line looks a bit flawed IMO. I would love to know the correct lupdate line. Unfortunately, I'm not very good in reading CMake yet.
(I intentionally removed the
-no-obsolete
argument because it deletes old translations. It is generally a bad idea to delete obsolete translations by default because obsolete translations can still be useful for translators to pick up similar translators. Especially if modules get moved and renamed around all the time. Qt Linguist is quite powerful in that regard. The only case where I recommend this argument is when a translation is complete or near-complete. It's only text, the few bytes you save aren't worth it IMO.)Features:
The translation is not complete, but it's about 3000/3200. There are many very difficult strings which seem to require expert knowledge. It would be nice if strings had context and/or translator comments (a core feature of the Qt translation system).
This translation was extensively tested at commit 3562bbe. Feel free to do the same.