Fuse Rhythm to Melody

[regulus79]

Decription

This feature allows the user to select two sets of clips on different tracks; one with the rhythm, and one with the melody. Then, by rightclicking on one of the melody clips, they can select "Fuse Rhythm to Melody," which will replace the old melody clips with a new clip which contains all the same notes, but while the keys of the notes are taken from the melody clips, the positions, velocity, and panning are taken from the rhythm clips.

Based on #7126

2024-12-09.14-55-47.mp4

[xor32dotcom]

i second this commit as i came up with the idea behind the feature as mentioned on the merge description.

Apparently it has a bug or two but this is 100% in at least a partial usable state for a nightly release

[regulus79]

What bugs have you been encountering?

[xor32dotcom]

came up with the best instrument to reuse this code if needed
"transcriptor"

[tresf]

This is a cool feature. Embarrassingly I'm not exactly sure how to use it, but I'll offer some early feedback.

• I think any feature that automagically uses a source and target should have some hand-holding. For example, "Right click on the melody" is a bit ambiguous. If the context menu could help explain what the action is going to do (e.g. "Fuse Noisy Guitar (Rhythm) to Horn (Melody)") this might be a bit easier to understand the flow of.
• The fact that this context menu item is missing unless two separate track patterns are selected makes it a bit hard to stumble upon this feature. It may make sense to offer it grayed-out with some help text for the user to discover on their own.
• The length acts weird sometimes. I'm not sure why.

Here's some very basic testing:
https://youtu.be/MZn1b-_eSbc

[regulus79]

Thank you for testing this!

However, michealgregorius gave some feedback in #7126 regarding this feature which makes me want to potentially hold off on this PR. The way this feature works with selections and rightclicking is not ideal. This sort of feature is only really useful for a few people in very rare cases, and having it in the rightclick menu does not seem appropriate. I think it may be better to wait until midi routing and midi effect support is implemented to add this feature. But I would love to hear everyone else's thoughts too.

[tresf]

@regulus79 what would you like to do? Would you like to close this PR now and reference it at a later time?

[regulus79]

If we are trying to archive stale/dormant PRs, I think that may be the right choice.