Update mute and solo buttons, add them to instrument windows #7708
Conversation
|
From the screenshot you provided, it looks like the mute and solo buttons are being merged into the same space as that of the volume knob. I'm thinking having a separate section for the mute and solo buttons (with a label like |
|
Here's what that looks like: |
That looks a lot better IMO! |
Co-authored-by: Sotonye Atemie <[email protected]>
|
To me the knobs feel a bit crowded, almost like the pitch range lcd should be moved closer to the channel lcd, idk |
I think there was some separation already added before this PR, but since we need that space now it's probably okay to remove. |
|
If we're going to address the lack of real estate in this PR, I would like to move the oversized preset save button to the left of the preset name, and make it the same size as the previous/next instrument buttons. Wait, do we really need the previous/next instrument buttons in the first place? I don't think I've ever used them, since I just click on the specific instrument I want to edit from the track view. Here's what it could look like if the previous/next buttons were replaced by the save button (this one is a hasty photoshop job) |
- Change label from "M/S" to "M&S", as to not be confused with mid/side - Adjust layout to preserve space between panning and pitch bend controls
|
After some more discussion in the Discord, there may be some other changes after all. |
rubiefawn
changed the title
Since SVGs can be used directly
- Updates the track mute/solo buttons - Makes the compact track view slightly larger to fit new assets (sorry) - Update mixer mute/solo buttons - Add mute/solo buttons to sample track window to match instruments
Updates mute/solo buttons with new assets (slashed speaker icon, headphone icon) to better communicate their purpose, since the current LED assets can be ambiguous without labels. Additionally, resolves #2685 by adding mute and solo controls to instrument track windows and sample track windows next to the volume knob.