Avoid reflecting invalid URL parameter - prevent false positive #6596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-adam
approved these changes
Apr 23, 2025
| catch (IllegalArgumentException e) | ||
| { | ||
| throw new NotFoundException("Invalid renderAs value"); | ||
| } |
There was a problem hiding this comment.
Since PAGE appears to be the default, you could default to that for invalid value as well:
EnumUtils.getEnum(FileContentController.RenderStyle.class, renderAs.toUpperCase(), FileContentController.RenderStyle.PAGE);
There was a problem hiding this comment.
I considered that but opted to be a little stricter. I don't think we've seen this exception aside from the crawler/scanner so I don't think we need to be overly tolerant.
Good to know about EnumUtils though - that wasn't on my radar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
A security scanner is tripping on a reflected, properly encoded URL parameter value. It's not especially helpful for users so we can just avoid including it on the 404.
Changes