Skip to content

Refactor AdminConsole vs. OptionalFeatureService #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

labkey-adam
Copy link
Contributor

@labkey-adam labkey-adam commented Jul 8, 2025

Rationale

Register feature flag via OptionalFeatureService. Move registration later in module lifecycle to ensure service is ready.

Related Pull Requests

@labkey-adam labkey-adam requested a review from a team July 8, 2025 18:48
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still happen soon enough for startup properties work?

@labkey-adam
Copy link
Contributor Author

Does this still happen soon enough for startup properties work?

Yes, init() is very very early; typically, the earliest module code that runs. And startup properties are handled very very late, see OptionalFeatureStartupListener.

@labkey-adam labkey-adam merged commit c3ec26f into develop Jul 15, 2025
7 of 10 checks passed
@labkey-adam labkey-adam deleted the fb_optional_feature_service branch July 15, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants