Inspector+UI: Close inspector on inspector.js' window.close()

This brings keyboard shortcuts for the inspector up with common
convention in FF and Chrome: Ctrl+Shift+C now also opens the inspector,
and F12 and Ctrl+Shift+I now close the inspector when the inspector
window is focused.

Resolves #972

Base/res/ladybird/inspector.js

@@ -771,6 +771,8 @@ document.addEventListener("DOMContentLoaded", () => {
         const LEFT_ARROW_KEYCODE = 37;
         const RETURN_KEYCODE = 13;
         const SPACE_KEYCODE = 32;
+        const F12_KEYCODE = 123;
+        const LETTER_I_KEYCODE = 73;
 
         const move = delta => {
             let selectedIndex = visibleDOMNodes.indexOf(selectedDOMNode);
@@ -785,6 +787,16 @@ document.addEventListener("DOMContentLoaded", () => {
             }
         };
 
+        let isF12Close = event.keyCode == F12_KEYCODE;
+        let isCtrlShiftIClose =
+               event.keyCode == LETTER_I_KEYCODE
+            && event.composed
+            && event.ctrlKey
+            && event.shiftKey;
+
+        if (isF12Close || isCtrlShiftIClose)
+            window.close();
+
         if (document.activeElement.tagName !== "INPUT") {
             const isSummary = selectedDOMNode.parentNode.tagName === "SUMMARY";
             const isDiv = selectedDOMNode.parentNode.tagName === "DIV";

UI/Qt/BrowserWindow.cpp

@@ -355,7 +355,7 @@ BrowserWindow::BrowserWindow(Vector<URL::URL> const& initial_urls, IsPopupWindow
 
     auto* inspector_action = new QAction("Open &Inspector", this);
     inspector_action->setIcon(load_icon_from_uri("resource://icons/browser/dom-tree.png"sv));
-    inspector_action->setShortcuts({ QKeySequence("Ctrl+Shift+I"), QKeySequence("F12") });
+    inspector_action->setShortcuts({ QKeySequence("Ctrl+Shift+I"), QKeySequence("Ctrl+Shift+C"), QKeySequence("F12") });
     inspect_menu->addAction(inspector_action);
     QObject::connect(inspector_action, &QAction::triggered, this, [this] {
         if (m_current_tab) {

UI/Qt/InspectorWidget.cpp

@@ -25,6 +25,10 @@ InspectorWidget::InspectorWidget(QWidget* tab, WebContentView& content_view)
     : QWidget(tab, Qt::Window)
 {
     m_inspector_view = new WebContentView(this);
+    m_inspector_view->on_close = [this] {
+        close();
+        emit closed();
+    };
 
     if (is_using_dark_system_theme(*this))
         m_inspector_view->update_palette(WebContentView::PaletteMode::Dark);

UI/Qt/InspectorWidget.h

@@ -35,6 +35,9 @@ class InspectorWidget final : public QWidget {
 public slots:
     void device_pixel_ratio_changed(qreal dpi);
 
+signals:
+    void closed();
+
 private:
     virtual bool event(QEvent*) override;
     void closeEvent(QCloseEvent*) override;

UI/Qt/Tab.cpp

@@ -889,10 +889,23 @@ void Tab::recreate_toolbar_icons()
     m_hamburger_button->setIcon(create_tvg_icon_with_theme_colors("hamburger", palette()));
 }
 
+void Tab::recreate_inspector()
+{
+    if (m_inspector_widget)
+        m_inspector_widget->deleteLater();
+
+    m_inspector_widget = new InspectorWidget(this, view());
+
+    QObject::connect(m_inspector_widget, &InspectorWidget::closed, [this] {
+        m_inspector_widget->deleteLater();
+        m_inspector_widget = nullptr;
+    });
+}
+
 void Tab::show_inspector_window(InspectorTarget inspector_target)
 {
     if (!m_inspector_widget)
-        m_inspector_widget = new InspectorWidget(this, view());
+        recreate_inspector();
     else
         m_inspector_widget->inspect();
 

UI/Qt/Tab.h

@@ -106,6 +106,8 @@ public slots:
 
     void close_sub_widgets();
 
+    void recreate_inspector();
+
     QBoxLayout* m_layout { nullptr };
     QToolBar* m_toolbar { nullptr };
     QToolButton* m_hamburger_button { nullptr };