LibWeb: Don't try to wait for HTTP server to exit if kill call fails #2682
+6
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a crash I saw locally where
headless-browser
would always crash with the following error just prior to exit:This happened because the call to
waitpid
failed for the HTTP server process. This was because the HTTP server failed to start on my local machine because the address it wanted to use was already in use.We now don't call
waitpid
if the prior call tokill
failed.I've also included a small fix to LibCore to return the correct error code from
Process::wait_for_termination()
ifwaitpid
fails.