LibWeb/CSS: Interpret NaN as 0 when resolving alpha #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasChollet
force-pushed
the
no_more_nan
branch
from
36adc26
to
2d42387
Compare
Fixes the crash in css/css-color/parsing/color-valid-hwb.html. The crash was probably introduced in 248e4bb, as it was the first commit to VERIFY that the value given to `Color::with_opacity` were in the correct range. As the values in color-valid-hwb.html were resolved as NaN, the check never passed.
LucasChollet
force-pushed
the
no_more_nan
branch
from
2d42387
to
414d91a
Compare
AtkinsSJ
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crash in css/css-color/parsing/color-valid-hwb.html.
The crash was probably introduced in 248e4bb, as it was the first
commit to VERIFY that the value given to
Color::with_opacitywere inthe correct range. As the values in color-valid-hwb.html were resolved
as NaN, the check never passed.
And that I'm not sure this is the correct place to do this "clamping". Indeed, no clamping is done for other channels, and it seems that the spec only requires it for rgb-based color space (here and that spec issue seems to be relevant).EDIT from the next day: After reading the spec a bit more: