AK: Store JSON keys and values as WTF-8 strings #2736
+228
−217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has conflicts. |
The value will be `null` if the `Optional` is empty, and `T` otherwise.
JSON can only contain WTF-8 encoded text, so it makes sense to type them as such. Also turn JSON keys into `FlyString`s, to reduce memory usage and increase performance of lookups.
yyny
force-pushed
the
deprecated-fly-string-smol
branch
from
818a7b9
to
315a18a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON can only contain WTF-8 encoded text, so it makes sense to type them as such. Also turn JSON keys into
FlyStrings, to reduce memory usage and increase performance of lookups.Part of the improvements made in #2493.