Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Load external scripts in SVG #2738

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shlyakpavel
Copy link
Contributor

@shlyakpavel shlyakpavel commented Dec 3, 2024

This works. I have a local interactive test, I need to edit it to add to our test suite. Meanwhile, are there any related WPTs?


// Fetch the external script content
auto request = LoadRequest::create_for_url_on_page(script_url, &document().page());
auto resource = ResourceLoader::the().load_resource(Resource::Type::Generic, request);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to use fetch, see: #2634

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a right thing to do, but looks overcomplicated. I haven't found a simple few-lines way to do that (yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants