Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lua][command] !quest var target #7184

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

KnowOne134
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

fetch targets info instead of just player that ran command

Steps to test these changes

!quest logid questid playerName
will fetch vars for the playerName target instead of yourself

@zach2good
Copy link
Contributor

It seems like I didn't add getCharVarsWithPrefix to the CBaseEntity spec file scripts/specs/core/CBaseEntity.lua, can you add it while you're here please?

@KnowOne134
Copy link
Contributor Author

Can try. Not sure what I'm doing in there

@zach2good
Copy link
Contributor

zach2good commented Mar 6, 2025

---@param prefix string
---@return table
function CBaseEntity:getCharVarsWithPrefix(prefix)
end

@KnowOne134
Copy link
Contributor Author

Added

@zach2good zach2good merged commit 1cbeb11 into LandSandBoat:base Mar 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants