-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Ruby 3.3.0 and Implement GA Ruby Version Matrix Testing #148
Open
oroth8
wants to merge
9
commits into
main
Choose a base branch
from
ruby-version-matrix-ci
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
14b905c
create versionci.yml for ruby version matrix testing via github actions
oroth8 282731c
remove rubocop from jobs
oroth8 2903e7f
update bundler and actionpack
oroth8 2b0bac3
bundle lock --add-platform x86_64-linux
oroth8 ef40312
add fail-fast: false
oroth8 4de6580
update ruby version matrix
oroth8 c37fa05
upgrade to ruby 3.2.2, fix 3.x ruby issues
oroth8 c73adea
upgrade to ruby 3.3.0
oroth8 7091f88
update gem version and documentation to 5.0.0
oroth8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
name: Version CI | ||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
- main | ||
jobs: | ||
test: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
ruby: ["3.2.0", "3.2.2", "3.3.0"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: ruby/setup-ruby@v1 | ||
with: | ||
ruby-version: ${{ matrix.ruby }} | ||
bundler-cache: true | ||
- run: bundle exec rspec |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.6.5 | ||
3.3.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,68 +1,101 @@ | ||
PATH | ||
remote: . | ||
specs: | ||
decanter (4.0.4) | ||
actionpack (>= 4.2.10) | ||
decanter (5.0.0) | ||
actionpack (>= 7.1.3.2) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this change essentially restrict the usage of Decanter v5 to apps with Rails 7 and above? |
||
activesupport | ||
rails-html-sanitizer (>= 1.0.4) | ||
|
||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
actionpack (5.2.4.4) | ||
actionview (= 5.2.4.4) | ||
activesupport (= 5.2.4.4) | ||
rack (~> 2.0, >= 2.0.8) | ||
actionpack (7.1.3.2) | ||
actionview (= 7.1.3.2) | ||
activesupport (= 7.1.3.2) | ||
nokogiri (>= 1.8.5) | ||
racc | ||
rack (>= 2.2.4) | ||
rack-session (>= 1.0.1) | ||
rack-test (>= 0.6.3) | ||
rails-dom-testing (~> 2.0) | ||
rails-html-sanitizer (~> 1.0, >= 1.0.2) | ||
actionview (5.2.4.4) | ||
activesupport (= 5.2.4.4) | ||
rails-dom-testing (~> 2.2) | ||
rails-html-sanitizer (~> 1.6) | ||
actionview (7.1.3.2) | ||
activesupport (= 7.1.3.2) | ||
builder (~> 3.1) | ||
erubi (~> 1.4) | ||
rails-dom-testing (~> 2.0) | ||
rails-html-sanitizer (~> 1.0, >= 1.0.3) | ||
activesupport (5.2.4.4) | ||
erubi (~> 1.11) | ||
rails-dom-testing (~> 2.2) | ||
rails-html-sanitizer (~> 1.6) | ||
activesupport (7.1.3.2) | ||
base64 | ||
bigdecimal | ||
concurrent-ruby (~> 1.0, >= 1.0.2) | ||
i18n (>= 0.7, < 2) | ||
minitest (~> 5.1) | ||
tzinfo (~> 1.1) | ||
connection_pool (>= 2.2.5) | ||
drb | ||
i18n (>= 1.6, < 2) | ||
minitest (>= 5.1) | ||
mutex_m | ||
tzinfo (~> 2.0) | ||
base64 (0.2.0) | ||
bigdecimal (3.1.7) | ||
builder (3.2.4) | ||
concurrent-ruby (1.1.7) | ||
concurrent-ruby (1.2.3) | ||
connection_pool (2.4.1) | ||
crass (1.0.6) | ||
diff-lcs (1.4.4) | ||
diff-lcs (1.5.1) | ||
docile (1.1.5) | ||
dotenv (2.2.1) | ||
erubi (1.9.0) | ||
i18n (1.8.5) | ||
dotenv (3.1.1) | ||
drb (2.2.1) | ||
erubi (1.12.0) | ||
i18n (1.14.4) | ||
concurrent-ruby (~> 1.0) | ||
json (2.3.0) | ||
loofah (2.7.0) | ||
io-console (0.7.2) | ||
irb (1.13.0) | ||
rdoc (>= 4.0.0) | ||
reline (>= 0.4.2) | ||
json (2.7.2) | ||
loofah (2.22.0) | ||
crass (~> 1.0.2) | ||
nokogiri (>= 1.5.9) | ||
method_source (1.0.0) | ||
mini_portile2 (2.4.0) | ||
minitest (5.14.2) | ||
nokogiri (1.10.10) | ||
mini_portile2 (~> 2.4.0) | ||
rack (2.2.3) | ||
rack-test (1.1.0) | ||
rack (>= 1.0, < 3) | ||
rails-dom-testing (2.0.3) | ||
activesupport (>= 4.2.0) | ||
nokogiri (>= 1.12.0) | ||
minitest (5.22.3) | ||
mutex_m (0.2.0) | ||
nokogiri (1.16.4-arm64-darwin) | ||
racc (~> 1.4) | ||
nokogiri (1.16.4-x86_64-linux) | ||
racc (~> 1.4) | ||
psych (5.1.2) | ||
stringio | ||
racc (1.7.3) | ||
rack (3.0.10) | ||
rack-session (2.0.0) | ||
rack (>= 3.0.0) | ||
rack-test (2.1.0) | ||
rack (>= 1.3) | ||
rackup (2.1.0) | ||
rack (>= 3) | ||
webrick (~> 1.8) | ||
rails-dom-testing (2.2.0) | ||
activesupport (>= 5.0.0) | ||
minitest | ||
nokogiri (>= 1.6) | ||
rails-html-sanitizer (1.3.0) | ||
loofah (~> 2.3) | ||
railties (5.2.4.4) | ||
actionpack (= 5.2.4.4) | ||
activesupport (= 5.2.4.4) | ||
method_source | ||
rake (>= 0.8.7) | ||
thor (>= 0.19.0, < 2.0) | ||
rails-html-sanitizer (1.6.0) | ||
loofah (~> 2.21) | ||
nokogiri (~> 1.14) | ||
railties (7.1.3.2) | ||
actionpack (= 7.1.3.2) | ||
activesupport (= 7.1.3.2) | ||
irb | ||
rackup (>= 1.0.0) | ||
rake (>= 12.2) | ||
thor (~> 1.0, >= 1.2.2) | ||
zeitwerk (~> 2.6) | ||
rake (12.3.3) | ||
rdoc (6.6.3.1) | ||
psych (>= 4.0.0) | ||
reline (0.5.5) | ||
io-console (~> 0.5) | ||
rspec-core (3.9.3) | ||
rspec-support (~> 3.9.3) | ||
rspec-expectations (3.9.3) | ||
rspec-expectations (3.9.4) | ||
diff-lcs (>= 1.2.0, < 2.0) | ||
rspec-support (~> 3.9.0) | ||
rspec-mocks (3.9.1) | ||
|
@@ -82,21 +115,25 @@ GEM | |
json (>= 1.8, < 3) | ||
simplecov-html (~> 0.10.0) | ||
simplecov-html (0.10.2) | ||
thor (1.0.1) | ||
thread_safe (0.3.6) | ||
tzinfo (1.2.7) | ||
thread_safe (~> 0.1) | ||
stringio (3.1.0) | ||
thor (1.3.1) | ||
tzinfo (2.0.6) | ||
concurrent-ruby (~> 1.0) | ||
webrick (1.8.1) | ||
zeitwerk (2.6.13) | ||
|
||
PLATFORMS | ||
ruby | ||
arm64-darwin-22 | ||
arm64-darwin-23 | ||
x86_64-linux | ||
|
||
DEPENDENCIES | ||
bundler (~> 1.9) | ||
bundler (~> 2.4.22) | ||
decanter! | ||
dotenv | ||
rake (~> 12.0) | ||
rspec-rails (~> 3.9) | ||
simplecov (~> 0.15.1) | ||
|
||
BUNDLED WITH | ||
1.17.3 | ||
2.4.22 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
# coding: utf-8 | ||
lib = File.expand_path('../lib', __FILE__) | ||
lib = File.expand_path('lib', __dir__) | ||
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) | ||
require 'decanter/version' | ||
|
||
|
@@ -9,29 +8,28 @@ Gem::Specification.new do |spec| | |
spec.authors = ['Ryan Francis', 'David Corwin'] | ||
spec.email = ['[email protected]'] | ||
|
||
spec.summary = %q{Form Parser for Rails} | ||
spec.description = %q{Decanter aims to reduce complexity in Rails controllers by creating a place for transforming data before it hits the model and database.} | ||
spec.summary = 'Form Parser for Rails' | ||
spec.description = 'Decanter aims to reduce complexity in Rails controllers by creating a place for transforming data before it hits the model and database.' | ||
spec.homepage = 'https://github.com/launchpadlab/decanter' | ||
spec.license = 'MIT' | ||
spec.required_ruby_version = '>= 3.2.0' | ||
|
||
# Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or | ||
# delete this section to allow pushing this gem to any host. | ||
if spec.respond_to?(:metadata) | ||
spec.metadata['allowed_push_host'] = 'https://rubygems.org' | ||
else | ||
raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.' | ||
end | ||
raise 'RubyGems 2.0 or newer is required to protect against public gem pushes.' unless spec.respond_to?(:metadata) | ||
|
||
spec.metadata['allowed_push_host'] = 'https://rubygems.org' | ||
|
||
spec.files = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } | ||
spec.bindir = 'exe' | ||
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | ||
spec.require_paths = ['lib'] | ||
|
||
spec.add_dependency 'actionpack', '>= 4.2.10' | ||
spec.add_dependency 'actionpack', '>= 7.1.3.2' | ||
spec.add_dependency 'activesupport' | ||
spec.add_dependency 'rails-html-sanitizer', '>= 1.0.4' | ||
|
||
spec.add_development_dependency 'bundler', '~> 1.9' | ||
spec.add_development_dependency 'bundler', '~> 2.4.22' | ||
spec.add_development_dependency 'dotenv' | ||
spec.add_development_dependency 'rake', '~> 12.0' | ||
spec.add_development_dependency 'rspec-rails', '~> 3.9' | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to specify "all patch versions greater than 3.2.0"? Or better yet, "all latest stable releases greater than X"? Or will we need to update this as and when new releases have come out?