Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate no-unreachable rule to warning #14

Closed
dpikt opened this issue May 15, 2019 · 1 comment · Fixed by #16
Closed

Deprecate no-unreachable rule to warning #14

dpikt opened this issue May 15, 2019 · 1 comment · Fixed by #16
Milestone
v1 Enhancements

Comments

@dpikt
Copy link
Contributor

dpikt commented May 15, 2019

I run into this rule a lot when debugging and it's a waste of time to comment out code just to temporarily pass the rule. @chawes13 are you in favor of this change?
@dpikt dpikt added this to the v1 Enhancements milestone May 15, 2019
@chawes13
Copy link
Contributor

Personally I've never experienced this issue. I support making this a warning

@chawes13 chawes13 removed their assignment May 15, 2019
@dpikt dpikt mentioned this issue Jun 11, 2019
Merged
@dpikt dpikt closed this as completed in #16 Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1 Enhancements
Development

Successfully merging a pull request may close this issue.

Deprecate no-unreachable LaunchPadLab/eslint-config
2 participants
@dpikt @chawes13