Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate no-unreachable #16

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Deprecate no-unreachable #16

merged 2 commits into from
Jun 11, 2019

Conversation

dpikt
Copy link
Contributor

@dpikt dpikt commented Jun 11, 2019

Resolves #14

Getting some minor changes in before adding the a11y rules 😄

@dpikt dpikt requested a review from chawes13 June 11, 2019 20:53
chawes13
chawes13 reviewed Jun 11, 2019
View reviewed changes
Copy link
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be set to 'off'? Generally our CI runs with --max-warnings=0 right?

@dpikt
Copy link
Contributor Author

dpikt commented Jun 11, 2019

I still want it to warn me, I just don't want it to block compilation while I'm debugging locally.

@chawes13
Copy link
Contributor

Wait I think I remember the context of #14. So the dev build will compile, but won't pass CI with this rule right?

chawes13
chawes13 approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only I was as smart as I was a few weeks ago! This looks great

@dpikt dpikt merged commit 4fa5b86 into master Jun 11, 2019
@dpikt dpikt deleted the no-unreachable branch June 11, 2019 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chawes13 chawes13 chawes13 approved these changes

Assignees

@chawes13 chawes13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate no-unreachable rule to warning
3 participants
@dpikt @chawes13 @lpluser