Sortable table row re-rendering fix (#456)

* Add exhaustive dependencies to data memoized value * Bump patch
LaunchPadLab · Oct 30, 2020 · 0ea9404 · 0ea9404
1 parent f172bc9
commit 0ea9404
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@launchpadlab/lp-components",
-  "version": "5.1.0",
+  "version": "5.1.1",
   "engines": {
     "node": "^8.0.0 || ^10.13.0 || ^12.0.0"
   },

diff --git a/src/tables/sortable-table.js b/src/tables/sortable-table.js
@@ -121,7 +121,7 @@ function SortableTable({
       )
       return sorted
     }
-  }, [ascending, sortPath, sortFunc, valueGetter])
+  }, [ascending, sortPath, sortFunc, valueGetter, controlled, disableSort, disableReverse, unsortedData])
 
   const handleColumnChange = (column) => {
     if (column.disabled) return

diff --git a/test/tables/sortable-table.test.js b/test/tables/sortable-table.test.js
@@ -324,3 +324,14 @@ test('`valueGetter` column can be the initial column and is sorted ascending', (
   expect(myValueGetter).toHaveBeenCalled()
 })
 
+test('table data is updated when data prop changes', () => {
+  const newTableData = [{ name: 'Kortney' }]
+  const wrapper = mount(
+    <SortableTable data={tableData}>
+      <Column name="name" />
+    </SortableTable>
+  )
+  expect(wrapper.find('td').first().text()).toEqual('Kim')
+  wrapper.setProps({ data: newTableData })
+  expect(wrapper.find('td').first().text()).toEqual('Kortney')
+})