Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate enzyme to testing library #586

Merged
merged 64 commits into from
Sep 11, 2023
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
08b1a65
Set up React Testing Library
josiasds Mar 13, 2023
9b16899
Migrate Spinner
josiasds Mar 13, 2023
943f105
convert button tests from enzyme to rtl
aojin Mar 22, 2023
f71a8cb
remove unused imports
aojin Mar 22, 2023
305230b
remove unused import
aojin Mar 22, 2023
df47bb0
Update jest and set test environment to jsdom
josiasds Apr 27, 2023
a9643cf
Bump version
josiasds Apr 27, 2023
46fe18e
update checkbox.test.js tests
aojin May 29, 2023
7a1a23e
checkbox.test.js and checkbox-group.test.js complete
aojin May 29, 2023
37dffab
update button.test.js to use userevent
aojin May 29, 2023
0657a87
update color-input.test.js to rtl
aojin May 29, 2023
605072d
remove unused imports
aojin May 29, 2023
6e7e647
update date input
aojin May 30, 2023
f3ffe10
complete color-input and date-input
aojin May 31, 2023
4db55ea
complete dropdown-checkbox-group
aojin May 31, 2023
ca49de6
complete hidden input
aojin May 31, 2023
c81e249
complete icon-input
aojin May 31, 2023
c69b700
Fix date input issues
chawes13 Aug 4, 2023
fef7199
RTL migration: controls (#602)
chawes13 Aug 7, 2023
4359649
RTL migration: modal (#601)
chawes13 Aug 7, 2023
a99338f
RTL migration: indicators (#600)
chawes13 Aug 7, 2023
0c4d1e6
Partial cleanup; Address code review
josiasds Aug 14, 2023
54228c2
Remove unecessary test
josiasds Aug 14, 2023
e846098
Remove moment dependency from DateInput test
josiasds Aug 15, 2023
db3c8d7
Update ColorPicker component
josiasds Aug 15, 2023
56e6d66
Update DropdownCheckboxGroup
josiasds Aug 15, 2023
70f33f6
Update HiddenInput
josiasds Aug 15, 2023
9839116
Update IconInput
josiasds Aug 15, 2023
ac42846
Update Spinner component
josiasds Aug 15, 2023
63738dd
Bump minor version
josiasds Aug 15, 2023
01e41e9
Merge branch 'main' into migrate-enzyme-to-testing-library
chawes13 Aug 15, 2023
f006f4e
Address comments
josiasds Aug 16, 2023
b6306df
Merge branch 'migrate-enzyme-to-testing-library' of github.com:Launch…
josiasds Aug 16, 2023
dac1b9d
Merge branch 'main' into migrate-enzyme-to-testing-library
chawes13 Aug 22, 2023
143aba0
Fix trigger on keys util
chawes13 Aug 22, 2023
455998c
Migrate color-picker
chawes13 Aug 22, 2023
d9406c2
RTL migration: tables (#603)
chawes13 Aug 25, 2023
7eec13e
RTL migration: labels (#607)
chawes13 Aug 25, 2023
8ecd5fb
RTL migration: inputs (#604)
chawes13 Aug 25, 2023
cf5587f
RTL migration: file inputs (#590)
josiasds Aug 25, 2023
ce8827b
Remove enzyme
chawes13 Aug 25, 2023
1177fde
Add act back to file input
chawes13 Aug 25, 2023
4c0a212
Avoid race conditions with act
chawes13 Aug 25, 2023
a55ca33
Update lock
chawes13 Sep 5, 2023
d0a2b15
Add test for read helper
chawes13 Sep 5, 2023
23af73d
Mock server...better
chawes13 Sep 5, 2023
840fe5f
Address uncovered line in wrap-display-name
chawes13 Sep 5, 2023
1e7684f
Remove unused default
chawes13 Sep 5, 2023
00fcbe7
Add coverage for modal
chawes13 Sep 5, 2023
4d9272e
Increase dropdown select coverage
chawes13 Sep 5, 2023
86ba4fe
Increase color picker coverage
chawes13 Sep 5, 2023
065073d
Increase color-input coverage
chawes13 Sep 5, 2023
cc6c923
Increase to-hex coverage
chawes13 Sep 5, 2023
c1b9ff9
Increase paginator coverage
chawes13 Sep 5, 2023
cc26270
Increase masked input coverage
chawes13 Sep 5, 2023
20b5e67
Increase date input coverage
chawes13 Sep 5, 2023
0e39746
Increase radio group coverage
chawes13 Sep 5, 2023
e8cff67
Improve cloudinary-uploader coverage
chawes13 Sep 5, 2023
cd2541a
Improve coverage for getEnvVar
chawes13 Sep 5, 2023
2fdbfca
Improve sortable table coverage
chawes13 Sep 5, 2023
e02d1cc
Improve tab-bar coverage
chawes13 Sep 6, 2023
b5ebff7
Update trigger on keys
chawes13 Sep 6, 2023
65fb434
Add comment
chawes13 Sep 6, 2023
ec062bb
Replace act with waitFor
chawes13 Sep 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused default
chawes13 committed Sep 5, 2023
commit 1e7684f6156a49dfbbe5df8e8de9acd8b2652c3b
2 changes: 1 addition & 1 deletion src/tables/helpers/get-column-data.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { castArray, has } from '../../utils'

// Get column info from children via props
function getColumnData(children = [], doDisable) {
function getColumnData(children, doDisable) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only called in sortable-table, whose prop types require children. We were getting a flag for missing a branch here, but in reality this isn't a valid use of this util.

const childrenArray = castArray(children)
return childrenArray
.filter((child) => has(child, 'props'))