-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate enzyme to testing library #586
Merged
+2,889
−1,881
Merged
Changes from 1 commit
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
08b1a65
Set up React Testing Library
josiasds 9b16899
Migrate Spinner
josiasds 943f105
convert button tests from enzyme to rtl
aojin f71a8cb
remove unused imports
aojin 305230b
remove unused import
aojin df47bb0
Update jest and set test environment to jsdom
josiasds a9643cf
Bump version
josiasds 46fe18e
update checkbox.test.js tests
aojin 7a1a23e
checkbox.test.js and checkbox-group.test.js complete
aojin 37dffab
update button.test.js to use userevent
aojin 0657a87
update color-input.test.js to rtl
aojin 605072d
remove unused imports
aojin 6e7e647
update date input
aojin f3ffe10
complete color-input and date-input
aojin 4db55ea
complete dropdown-checkbox-group
aojin ca49de6
complete hidden input
aojin c81e249
complete icon-input
aojin c69b700
Fix date input issues
chawes13 fef7199
RTL migration: controls (#602)
chawes13 4359649
RTL migration: modal (#601)
chawes13 a99338f
RTL migration: indicators (#600)
chawes13 0c4d1e6
Partial cleanup; Address code review
josiasds 54228c2
Remove unecessary test
josiasds e846098
Remove moment dependency from DateInput test
josiasds db3c8d7
Update ColorPicker component
josiasds 56e6d66
Update DropdownCheckboxGroup
josiasds 70f33f6
Update HiddenInput
josiasds 9839116
Update IconInput
josiasds ac42846
Update Spinner component
josiasds 63738dd
Bump minor version
josiasds 01e41e9
Merge branch 'main' into migrate-enzyme-to-testing-library
chawes13 f006f4e
Address comments
josiasds b6306df
Merge branch 'migrate-enzyme-to-testing-library' of github.com:Launch…
josiasds dac1b9d
Merge branch 'main' into migrate-enzyme-to-testing-library
chawes13 143aba0
Fix trigger on keys util
chawes13 455998c
Migrate color-picker
chawes13 d9406c2
RTL migration: tables (#603)
chawes13 7eec13e
RTL migration: labels (#607)
chawes13 8ecd5fb
RTL migration: inputs (#604)
chawes13 cf5587f
RTL migration: file inputs (#590)
josiasds ce8827b
Remove enzyme
chawes13 1177fde
Add act back to file input
chawes13 4c0a212
Avoid race conditions with act
chawes13 a55ca33
Update lock
chawes13 d0a2b15
Add test for read helper
chawes13 23af73d
Mock server...better
chawes13 840fe5f
Address uncovered line in wrap-display-name
chawes13 1e7684f
Remove unused default
chawes13 00fcbe7
Add coverage for modal
chawes13 4d9272e
Increase dropdown select coverage
chawes13 86ba4fe
Increase color picker coverage
chawes13 065073d
Increase color-input coverage
chawes13 cc6c923
Increase to-hex coverage
chawes13 c1b9ff9
Increase paginator coverage
chawes13 cc26270
Increase masked input coverage
chawes13 20b5e67
Increase date input coverage
chawes13 0e39746
Increase radio group coverage
chawes13 e8cff67
Improve cloudinary-uploader coverage
chawes13 cd2541a
Improve coverage for getEnvVar
chawes13 2fdbfca
Improve sortable table coverage
chawes13 e02d1cc
Improve tab-bar coverage
chawes13 b5ebff7
Update trigger on keys
chawes13 65fb434
Add comment
chawes13 ec062bb
Replace act with waitFor
chawes13 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unused default
commit 1e7684f6156a49dfbbe5df8e8de9acd8b2652c3b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was only called in
sortable-table
, whose prop types require children. We were getting a flag for missing a branch here, but in reality this isn't a valid use of this util.