Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency is-promise to v4 #84

Closed
wants to merge 1 commit into from
Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 5, 2020

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
is-promise ^2.1.0 -> ^4.0.0 age adoption passing confidence

Release Notes

then/is-promise

v4.0.0

Compare Source

Breaking Changes

  • Use PromiseLike instead of Promise in TypeScript (#​40)

    This is only a breaking change for TypeScript users.

    In the following code:

    function foo(x: PromiseLike<string> | string) {
      if (isPromise(x)) {
        return x;
      } else {
        return Promise.resolve(x);
      }
    }

    TypeScript would previously have incorrectly inferred foo as returning Promisestring>when in fact it returnsPromiseLikestring>. The latest version fixes this. If you instead had the following code, it should work exactly the same as before:

    function foo(x: Promise<string> | string) {
      if (isPromise(x)) {
        return x;
      } else {
        return Promise.resolve(x);
      }
    }

    This update is to reflect the fact that is-promise does "duck" typing, rather than an instanceof check.

v3.0.0

Compare Source

Breaking Changes

  • Restricted "exports" in package.json (for node 14+) (#​30)

    The only ways to import this are now:

    import isPromise from 'is-promise';

    or

    const isPromise = require('is-promise');

    If you were requiring things like the package.json file within the package, these are not part of the public API, and will no longer be accessible.

  • is-promise now uses "default" exports in ES Modules environments (#​30)

    If you were using ES6 style imports via

    import * as isPromise from 'is-promise';

    you will need to update this to

    import isPromise from 'is-promise';

    If you were using CommonJS style require, no change is needed.

  • This package now comes bundled with TypeScript definitions (#​31)

    This means you may get new errors that you didn't see before if you are using TypeScript. If you are not using TypeScript, this change will not impact you.

v2.2.2

Compare Source

Removed ESM support that was added in 2.2.0 as it turns out to be a breaking change (see https://github.com/then/is-promise/issues/20)

v2.2.1

Compare Source

Attempted to fix ESM, but this is still broken for people who import the package.json file.

v2.2.0

Compare Source

  • Adds TypeScript definition
  • Adds support for ES Module style default import

This version of is-promse is broken. Please use 2.2.2


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/is-promise-4.x branch 2 times, most recently from d3230de to 9bca441 Compare September 16, 2021 15:47
@renovate renovate bot force-pushed the renovate/is-promise-4.x branch from 9bca441 to a949656 Compare December 17, 2021 18:43
@renovate renovate bot force-pushed the renovate/is-promise-4.x branch from a949656 to 328590f Compare February 23, 2022 15:23
@renovate
Copy link
Contributor Author

renovate bot commented Mar 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@chawes13
Copy link
Contributor

chawes13 commented Aug 1, 2023

Resolved by #111

@chawes13 chawes13 closed this Aug 1, 2023
@renovate
Copy link
Contributor Author

renovate bot commented Aug 1, 2023

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/is-promise-4.x branch August 1, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants