-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Routes file to move Layout within Route #39
base: main
Are you sure you want to change the base?
Conversation
@danparnella I used v9.0.0 for a new tag/release, so you'll need to bump this version whenever this gets merged. |
@josiasds Thanks for the heads up (and the comment bump on this one as I might have forgotten about this PR 😅)! |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@launchpadlab/lp-subsection-generator", | |||
"version": "9.0.0", | |||
"version": "10.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This felt like a big enough change for this repo to make it a new major version since it could change how styles are applied and how to set up routes files to match for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the changes are agreed upon, can you add some documentation to MIRATION.md
?
@danparnella I'm going to pass this one over to Mike since it seems like the conversation might have trailed off without a final resolution: https://github.com/LaunchPadLab/ionic-client-template/issues/43#issuecomment-1734579241. |
Resolves
Layout
component within Routes files to make sure that the native iOS swipe back functionality works as expected (with the view sliding animation).