Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Routes file to move Layout within Route #39

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

danparnella
Copy link

@danparnella danparnella commented Feb 16, 2024

Resolves

@josiasds
Copy link
Contributor

@danparnella I used v9.0.0 for a new tag/release, so you'll need to bump this version whenever this gets merged.

@danparnella
Copy link
Author

danparnella commented Mar 28, 2024

@josiasds Thanks for the heads up (and the comment bump on this one as I might have forgotten about this PR 😅)!

@@ -1,6 +1,6 @@
{
"name": "@launchpadlab/lp-subsection-generator",
"version": "9.0.0",
"version": "10.0.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This felt like a big enough change for this repo to make it a new major version since it could change how styles are applied and how to set up routes files to match for consistency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the changes are agreed upon, can you add some documentation to MIRATION.md?

@danparnella danparnella marked this pull request as ready for review March 28, 2024 17:22
@danparnella danparnella requested a review from chawes13 March 28, 2024 17:22
@chawes13
Copy link
Contributor

chawes13 commented Apr 2, 2024

@danparnella I'm going to pass this one over to Mike since it seems like the conversation might have trailed off without a final resolution: https://github.com/LaunchPadLab/ionic-client-template/issues/43#issuecomment-1734579241.

@chawes13 chawes13 requested review from mwislek and removed request for chawes13 April 2, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants