readmeeeee #40
Merged
readmeeeee #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
|
|
||
| ### Devise | ||
| [Devise][devise] is an amazing gem! It is perfect when you want an all-in-one solution that handles user authentication and associated flows for your Rails/ERB app. Everything is in the box, including the routes, controllers, views, and even mailers to handle user auth. But we often use Rails as an API and/or wanted more control over all those pieces and it became difficult to peel back all the layers to just to confirm a users email. | ||
|
|
There was a problem hiding this comment.
a user's > I think we need the possessive apostrophe here.
README.md
Outdated
| See the [Api Docs][docs] for more details. | ||
|
|
||
| ## Advanced | ||
| Sometimes in order to redeem a token, we want to make sure some additional information is present and possible save that to our model. For example, when implementing a password reset flow, we want to update the User with the new password and make sure that its valid. |
There was a problem hiding this comment.
possibly instead of possible
wade00
approved these changes
Apr 25, 2017
There was a problem hiding this comment.
I can definitely get by with this. I don't think I'd have any trouble getting set up.
The only feedback I have is that I stumbled over "tokenable" a few times. I'm used to hearing it around the office, but calling the action of confirming an account as a "tokenable" feels weird.
README.md
Outdated
| Does not take over your app, minimal magic, and only if you want it. Token Master works with your existing authentication solution. | ||
|
|
||
| ### Flexible | ||
| Works for Apis, ERB apps and everything in between. |
README.md
Outdated
|
|
||
| ... | ||
| Lets revisit the Quick Start and fill in the details. |
README.md
Outdated
|
|
||
| 1. In Rails apps by default, the Token Master module is included in your `ApplicationRecord` base class. However, if necessary, you can add this yourself by include the following in your class: |
|
@davemcorwin I "approved" the review even though I had a few comments. See above! |
|
ty @wade00! I tried to introduce the concept of a tokenable but it probably needs more work |
inveterateliterate
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polish up the readme #22