app: more logs for mining, wallet updates, net #16
Conversation
torkelrogstad
force-pushed
the
2025-01-24-mine-logs
branch
3 times, most recently
from
1aa232b to
de87372
Compare
torkelrogstad
changed the title
| tracing::debug!(%bmm_txid, "mine: confirming BMM..."); | ||
| if let Some((main_hash, header, body)) = | ||
| miner_write.confirm_bmm().await? | ||
| { | ||
| tracing::debug!( | ||
| "mine: confirmed BMM, submitting block {}", | ||
| header.hash() | ||
| %main_hash, side_hash = %header.hash(), "mine: confirmed BMM, submitting block", |
There was a problem hiding this comment.
Nit: There is no need to prefix logs with the function name. The logger should do that automatically. You can use tracing::instrument with skip_all if you want to construct a new span specific to the function.
|
Re. all the whitespace: we probably look at this differently. I think whitespace is a good way of logically chunking groups of code lines that "belong together", and avoiding whitespace quickly leads to walls of text that's tiring to read. I'd be fine with a strict standard for whitespace, if it's something we can automate through |
|
Re. the log lines including function names: that's not the case when I'm running locally. Is that perhaps something that needs to be configured? Providing example logs here |
torkelrogstad
force-pushed
the
2025-01-24-mine-logs
branch
from
5a49687 to
c1b2950
Compare
No description provided.