peer handling: friendlier error message on invalid address, more RPC output, introduce peer state concept #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-L2L
requested changes
Jan 30, 2025
torkelrogstad
changed the title
torkelrogstad
force-pushed
the
2025-01-30-peers
branch
from
42d743c to
4d6535b
Compare
Ash-L2L
reviewed
Jan 31, 2025
torkelrogstad
force-pushed
the
2025-01-30-peers
branch
from
977d2db to
c52a28e
Compare
Ash-L2L
reviewed
Feb 3, 2025
Ash-L2L
requested changes
Feb 3, 2025
torkelrogstad
force-pushed
the
2025-01-30-peers
branch
from
bccbc8d to
569928b
Compare
Ash-L2L
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14
In this PR we introduce a new
PeerStateenum. I'm not sure this is the ideal naming. There's already a similarly named struct innet. Open to suggestions!