multi: tracing in CLI, request ID handling #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-L2L
requested changes
Feb 10, 2025
Add capabilities for setting request IDs through header values, which we include in tracing spans. We then set randomly generated request IDs in the CLI, such that it's possible to trace requests/responses going through the system. This is conceptually very similar to LayerTwo-Labs/bip300301_enforcer#150. One would think that we could do this with the actual `id` field of the JSON-RPC bodies. This is not possible, because the `jsonrpsee` library does not make it possible to configure this. Upstream issue for this paritytech/jsonrpsee#1524
torkelrogstad
force-pushed
the
2025-02-09-tracing
branch
from
503b253 to
71c92d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add capabilities for setting request IDs through header values, which we include in tracing spans. We then set randomly generated request IDs in the CLI, such that it's possible to trace requests/responses going through the system.
This is conceptually very similar to LayerTwo-Labs/bip300301_enforcer#150.
One would think that we could do this with the actual
idfield of the JSON-RPC bodies. This is not possible, because thejsonrpseelibrary does not make it possible to configure this.Upstream issue for this paritytech/jsonrpsee#1524