multi: add endpoints for best mainchain and sidechain hashes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash-L2L
requested changes
Feb 26, 2025
app/rpc_server.rs
Outdated
| async fn get_best_sidechain_block_hash( | ||
| &self, | ||
| ) -> RpcResult<Option<thunder::types::BlockHash>> { | ||
| let Some(sidechain_hash) = |
There was a problem hiding this comment.
This could be
self.app.node.try_get_tip().map_err(custom_err)There was a problem hiding this comment.
haha yes indeed, don't know how that ended up in there
rpc-api/lib.rs
Outdated
|
|
||
| /// Get the best sidechain block hash known by Thunder | ||
| #[open_api_method(output_schema( | ||
| PartialSchema = "thunder_schema::BitcoinBlockHash" |
There was a problem hiding this comment.
This looks like the wrong schema - is it even necessary to specify the output schema here?
There was a problem hiding this comment.
Thx, updated the schema. I don't understand what's going on here at all to be honest.
torkelrogstad
force-pushed
the
2025-02-26-best-hash
branch
from
0940260 to
0321686
Compare
Ash-L2L
force-pushed
the
2025-02-26-best-hash
branch
from
0cfa05a to
13df2e2
Compare
Ash-L2L
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the output when fetching sidechain hashes is not really on a readable format...