-
Notifications
You must be signed in to change notification settings - Fork 11
feat: updated transfer ui with a cleaner look #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ronnakamoto
wants to merge
2
commits into
LayerTwo-Labs:master
Choose a base branch
from
ronnakamoto:transfer-new-ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+273
−142
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
//! Layout styling for the Thunder UI | ||
use eframe::egui::{self, Color32, Response, Ui}; | ||
|
||
/// Layout dimensions | ||
pub struct LayoutDimensions; | ||
|
||
impl LayoutDimensions { | ||
pub const CONTAINER_PADDING: f32 = 16.0; | ||
pub const SECTION_SPACING: f32 = 24.0; | ||
pub const ELEMENT_SPACING: f32 = 8.0; | ||
pub const SMALL_SPACING: f32 = 4.0; | ||
} | ||
|
||
/// Layout colors | ||
pub struct LayoutColors; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this a struct? This could be a module |
||
|
||
impl LayoutColors { | ||
pub const BACKGROUND: Color32 = Color32::from_rgb(0xF5, 0xF5, 0xF7); | ||
pub const CARD_BACKGROUND: Color32 = Color32::from_rgb(0xFF, 0xFF, 0xFF); | ||
pub const BORDER: Color32 = Color32::from_rgb(0xD2, 0xD2, 0xD7); | ||
} | ||
|
||
/// Layout UI extensions | ||
pub trait LayoutUiExt { | ||
/// Create a card container with proper spacing and borders | ||
fn layout_card<R>(&mut self, add_contents: impl FnOnce(&mut Ui) -> R) -> R; | ||
|
||
/// Add a section heading | ||
fn layout_heading(&mut self, text: &str) -> Response; | ||
} | ||
|
||
impl LayoutUiExt for Ui { | ||
fn layout_card<R>(&mut self, add_contents: impl FnOnce(&mut Ui) -> R) -> R { | ||
let frame = egui::Frame::none() | ||
.fill(LayoutColors::CARD_BACKGROUND) | ||
.stroke(egui::Stroke::new(1.0, LayoutColors::BORDER)) | ||
.inner_margin(LayoutDimensions::CONTAINER_PADDING); | ||
|
||
frame.show(self, add_contents).inner | ||
} | ||
|
||
fn layout_heading(&mut self, text: &str) -> Response { | ||
self.add_space(LayoutDimensions::ELEMENT_SPACING); | ||
let response = self.heading(text); | ||
self.add_space(LayoutDimensions::ELEMENT_SPACING); | ||
response | ||
} | ||
} | ||
|
||
/// Helper functions for layout | ||
pub struct LayoutHelpers; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this a struct? This could be a module |
||
|
||
impl LayoutHelpers { | ||
/// Create a BTC input field with label | ||
pub fn btc_input_field(ui: &mut Ui, value: &mut String, label: &str, hint: &str) -> Response { | ||
ui.add_space(LayoutDimensions::SMALL_SPACING); | ||
ui.label(label); | ||
ui.add_space(LayoutDimensions::SMALL_SPACING); | ||
|
||
ui.horizontal(|ui| { | ||
let text_edit = egui::TextEdit::singleline(value) | ||
.hint_text(hint) | ||
.desired_width(ui.available_width() - 40.0); | ||
|
||
let response = ui.add(text_edit); | ||
ui.add_space(LayoutDimensions::SMALL_SPACING); | ||
ui.label("BTC"); | ||
response | ||
}).inner | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a struct? This could be a module