Add separate timeout flag for writer #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
add-writer-timeout
branch
from
83221e4 to
2a2563d
Compare
samlaf
reviewed
Feb 8, 2024
ian-shim
force-pushed
the
add-writer-timeout
branch
from
2a2563d to
50b3365
Compare
samlaf
approved these changes
Feb 8, 2024
|
Awesome, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, it was using
rpcTimeoutDurationas a timeout for both read & write onchain. However, there should be two distinct timeouts for read & write operations.Solution
This PR distinguishes the two timeouts (read vs. write), and adds another flag to represent the write timeout as writing (sending transactions) onchain should take a lot longer time.
Ideally, the transaction manager in eigensdk supports retries and gas fee bumps, but this can be a temporary solution till that's supported.