Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove interfaces of el reader writer #301

Merged
merged 5 commits into from
Jul 18, 2024
Merged

refactor: remove interfaces of el reader writer #301

merged 5 commits into from
Jul 18, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

What Changed?

  • Remove unnecessary interface from EL contracts. Clients who use it can create their own interface and use methods as they need.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@shrimalmadhur shrimalmadhur requested a review from samlaf July 18, 2024 04:35
@shrimalmadhur shrimalmadhur requested a review from samlaf July 18, 2024 05:16
@shrimalmadhur shrimalmadhur merged commit 5f73199 into dev Jul 18, 2024
4 checks passed
@shrimalmadhur shrimalmadhur deleted the madhur/refactor-remove-interfaces branch July 18, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @samlaf