Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: chainReader invalid config tests #447

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

damiramirez
Copy link
Contributor

@damiramirez damiramirez commented Jan 17, 2025

What Changed?

This PR introduces tests to cover edge cases, including:

  • Scenarios where the configuration is empty.
  • Cases where invalid addresses are provided.

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

maximopalopoli added a commit to lambdaclass/eigensdk-go that referenced this pull request Jan 17, 2025
The structure is taken from this other PR that tests invalid config:
Layr-Labs#447. This is done this way
 to make easier future merges
@damiramirez damiramirez marked this pull request as ready for review January 17, 2025 19:11
Copy link
Contributor

@maximopalopoli maximopalopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

assert.NotNil(t, operatorDetails)
assert.Equal(t, op.Address, operatorDetails.Address)
assert.Equal(t, delay, operatorDetails.AllocationDelay)
t.Logf("Operator details: %+v", operatorDetails)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log has debugging purposes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 5b3acac

pablodeymo
pablodeymo previously approved these changes Jan 20, 2025
@pablodeymo pablodeymo added this pull request to the merge queue Jan 21, 2025
Merged via the queue into Layr-Labs:dev with commit 04449ff Jan 21, 2025
4 checks passed
@pablodeymo pablodeymo deleted the test/invalid-input-reader branch January 21, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants