refactor: common error interface for avsRegistry chainReader #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avsregistry-reader
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge
What Changed?
This PR can be seen as a continuation of the PRs #477 and #482, since expands the usage of the common custom error to the
avsRegistrychainReader.The idea is to use a common custom error in all SDK exposed functions, and make the error descriptive for the SDK user. For this reason, the Error custom struct is the same as the showed in #477.
The order of the error codes, the names of the errors themselves, or even the
Errorstruct attributes may change in future PRs.Note: this PR updates tests merged from #458 and should be merged after it.
Reviewer Checklist