Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add create slashable stake quorum func #531

Conversation

maximopalopoli
Copy link
Contributor

@maximopalopoli maximopalopoli commented Feb 6, 2025

What Changed?

Adds CreateSlashableStakeQuorum and a test case adding a slashable stake quorum and verifying registry coordinator's quorum number has increased.

Also aims to fix partially issue #518

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@maximopalopoli maximopalopoli marked this pull request as ready for review February 6, 2025 21:03
chainio/clients/avsregistry/writer.go Outdated Show resolved Hide resolved

chainWriter := clients.AvsRegistryChainWriter

// Beyond MaxOperatorCount, the other params are not used anywhere other than in registerOperatorWithChurn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an explanation to the struct elements, and also explains that does not matters the attribute values

chainio/clients/avsregistry/writer_test.go Show resolved Hide resolved
chainio/clients/avsregistry/writer.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaRedHand MegaRedHand added this pull request to the merge queue Feb 7, 2025
Merged via the queue into Layr-Labs:dev with commit 2cbfd15 Feb 7, 2025
9 checks passed
@MegaRedHand MegaRedHand deleted the feat/add-create-slashable-stake-quorum-func branch February 7, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants