Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement StakeRegistry view functions #536

Merged
merged 15 commits into from
Feb 10, 2025
Merged

feat: implement StakeRegistry view functions #536

merged 15 commits into from
Feb 10, 2025

Conversation

Sidu28
Copy link
Contributor

@Sidu28 Sidu28 commented Feb 7, 2025

Fixes # .

What Changed?

Add all the view functions to avsregistry reader:

  • weightOfOperatorForQuorum
  • strategyParamsLength
  • strategyParamsByIndex
  • getStakeHistoryLength
  • getStakeHistory
  • getLatestStakeUpdate
  • getStakeUpdateAtIndex
  • getStakeAtBlockNumber
  • getStakeUpdateIndexAtBlockNumber
  • getStakeAtBlockNumberAndIndex
  • getTotalStakeHistoryLength
  • getCurrentTotalStake
  • getTotalStakeUpdateAtIndex
  • getTotalStakeAtBlockNumberFromIndex
  • getTotalStakeIndicesAtBlockNumber

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@Sidu28 Sidu28 force-pushed the stakeregistry-functions branch from b87ca63 to e282c0b Compare February 9, 2025 18:28
@Sidu28 Sidu28 force-pushed the stakeregistry-functions branch 2 times, most recently from 42dfac2 to 22be7a1 Compare February 9, 2025 21:03
@Sidu28 Sidu28 marked this pull request as ready for review February 9, 2025 21:04
@Sidu28 Sidu28 requested a review from MegaRedHand February 9, 2025 21:04
@MegaRedHand MegaRedHand changed the title Stakeregistry functions feat: implement StakeRegistry view functions Feb 10, 2025
MegaRedHand
MegaRedHand previously approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from that, LGTM

@Sidu28 Sidu28 requested a review from MegaRedHand February 10, 2025 16:15
@MegaRedHand MegaRedHand added this pull request to the merge queue Feb 10, 2025
Merged via the queue into dev with commit 6c75e89 Feb 10, 2025
11 checks passed
@MegaRedHand MegaRedHand deleted the stakeregistry-functions branch February 10, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sidu28 @MegaRedHand